Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-19291

Use common header and footer for JSP pages

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • None
    • None
    • None

    Description

      Use header and footer in our *.jsp pages to avoid unnecessary redundancy (copy-paste of code)

      (Been sitting in my local repo for long, best to get following pesky user-facing things fixed before the next major release)
      Misc edits:

      • Due to redundancy, new additions make it to some places but not others. For eg there are missing links to "/logLevel", "/processRS.jsp" in few places.
      • Fix processMaster.jsp wrongly pointing to rs-status instead of master-status (probably due to copy paste from processRS.jsp)
      • Deleted a bunch of extraneous "</a>" in processMaster.jsp & processRS.jsp
      • Added missing </div> tag in snapshot.jsp
      • Deleted fossils of html5shiv.js. It's uses and the js itself were deleted in the commit "819aed4ccd073d818bfef5931ec8d248bfae5f1f"
      • Fixed wrongly matched heading tags
      • Deleted some unused variables

      Tested:
      Ran standalone cluster and opened each page to make sure it looked right.

      Sidenote:
      Looks like HBASE-3835 started the work of converting from jsp to jamon, but the work didn't finish. Now we have a mix of jsp and jamon. Needs reconciling, but later.

      Attachments

        1. HBASE-19291.master.001.patch
          56 kB
          Apekshit Sharma

        Issue Links

          Activity

            People

              appy Apekshit Sharma
              appy Apekshit Sharma
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: