[HBASE-18925] Need updated mockito for using java optional

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0-beta-1, 2.0.0
• Assignee: Apekshit Sharma
• Reporter: Apekshit Sharma
• Created: 03/Oct/17 03:18
• Updated: 21/Mar/18 22:21
• Resolved: 01/Nov/17 21:47

Description

Came up when i was trying to test HBASE-18878.
It kept failing because mock of RpcCall returned null where return type was Optional<User>.
Instead, we want it to return Optional.empty().
New mockito versions support this (and other java8 things) - https://github.com/mockito/mockito/wiki/What%27s-new-in-Mockito-2

We use mockito-all which was last released in Dec2014. However, mockito-core has had more than 50 releases after that (https://mvnrepository.com/artifact/org.mockito/mockito-core).
We need to change our deps from mockito-all to mockito-core.
However that comes with fair breakages, so this is not a simple task of changing pom files.

Issue Links

• links to: Review Board (master)