[HBASE-18830] TestCanaryTool does not check Canary monitor's error code

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0, 1.3.3, 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Chinmay Kulkarni
• Reporter: Chinmay Kulkarni
• Created: 15/Sep/17 23:48
• Updated: 14/Dec/18 10:08
• Resolved: 26/Sep/17 02:19

Description

None of the tests inside TestCanaryTool check Canary monitor's error code. Thus, it is possible that the monitor has registered an error and yet the tests pass. We should check the value returned by the ToolRunner.run() method inside each unit test.