[HBASE-18722] Replace copied guava code w/ pointer to the (shaded) lib

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Duplicate
• Labels: beginner
• Tags: beginner
• Assignee: Unassigned
• Reporter: Michael Stack
• Created: 30/Aug/17 20:34
• Updated: 01/Aug/18 06:21
• Resolved: 28/Dec/17 22:27

Description

I found a few bits of code copied from guava src:

./src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java: * Copied from guava source code v15 (LimitedInputStream)
./src/main/java/org/apache/hadoop/hbase/io/LimitInputStream.java: * allows to be compatible with guava 11 to 15+.
./src/main/java/org/apache/hadoop/hbase/util/ByteBufferUtils.java:         * from guava v21
./src/main/java/org/apache/hadoop/hbase/util/Bytes.java:             * comparator from guava v21

We can instead point back at guava implementations now we use shaded guava internally. No point having it in our code base when latest guava is on latest CLASSPATH (This wasn't always the case; this is why the code was copied into hbase).

Also, there are other copies other than the above.

Issue Links

• is related to: HBASE-19651 Remove LimitInputStream