[HBASE-18323] Remove multiple ACLs for the same user in kerberos

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.2.0, 3.0.0-alpha-1
• Fix Version/s: 1.4.0, 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Shibin Zhang
• Reporter: Shibin Zhang
• Created: 05/Jul/17 06:54
• Updated: 01/Aug/18 06:24
• Resolved: 25/Jul/17 22:27

Description

When deploy hbase in kerberos way ,there will be multiple acls in znode :
'world,'anyone
: r
'sasl,'hbase
: cdrwa
'sasl,'hbase
: cdrwa

I also see the related issue and apply the patch, like https://issues.apache.org/jira/browse/HBASE-17717
but in my environment ,this situation still appear,

After dig into the code , i found the reason in source code ZKUtil.createAcl is

if (zkw.isClientReadable(node))

{ LOG.error("isSecureZooKeeper user: clientReadable"); acls.addAll(Ids.CREATOR_ALL_ACL); acls.addAll(Ids.READ_ACL_UNSAFE); }

else

{ LOG.error("isSecureZooKeeper user: clientReadable no"); acls.addAll(Ids.CREATOR_ALL_ACL); }

acls.addAll(Ids.CREATOR_ALL_ACL);

Id AUTH_IDS = new Id("auth", "");

ArrayList<ACL> CREATOR_ALL_ACL = new ArrayList(Collections.singletonList(new ACL(31, AUTH_IDS)));

AUTH_IDS with "auth " will result current connection auth user add to znode acl ,
so it will appear multiple acls for same users.

I think this line of code we can remove : acls.addAll(Ids.CREATOR_ALL_ACL);

Issue Links

• is related to: HBASE-17717 Incorrect ZK ACL set for HBase superuser