Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-17488

WALEdit should be lazily instantiated

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • None
    • 1.4.0, 2.0.0
    • None
    • None
    • Reviewed
    • Hide
      prevent creating unused objects in the WALEdit's construction.
      +If the cp#preBatchMutate returns true, the WALEdit is useless. So we should create the WALEdit after step 2.
      +The cells came from cp should be counted because they are added into the WALEdit . The use case is the local index of phoenix
      +If the mutation contains the SKIP_WAL property, its cells aren't added into the WALEdit. So these cells shouldn't be counted.
      Show
      prevent creating unused objects in the WALEdit's construction. +If the cp#preBatchMutate returns true, the WALEdit is useless. So we should create the WALEdit after step 2. +The cells came from cp should be counted because they are added into the WALEdit . The use case is the local index of phoenix +If the mutation contains the SKIP_WAL property, its cells aren't added into the WALEdit. So these cells shouldn't be counted.

    Description

      Some trivial improvement.

      1. create the WALEdit on step 3 instead of step 2
      2. count the cells from coprocessor
      3. don’t count the mutations which contain the Durability.SKIP_WAL property

      Attachments

        1. HBASE-17488.branch-1.v0.patch
          2 kB
          Michael Stack
        2. HBASE-17488.branch-1.v0.patch
          2 kB
          Chia-Ping Tsai
        3. HBASE-17488.branch-1.v1.patch
          3 kB
          Chia-Ping Tsai
        4. HBASE-17488.v0.patch
          3 kB
          Chia-Ping Tsai

        Issue Links

          Activity

            People

              chia7712 Chia-Ping Tsai
              chia7712 Chia-Ping Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: