[HBASE-17431] Incorrect precheck condition in RoundRobinPool#get()

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Not A Problem
• Hadoop Flags: Reviewed
• Assignee: Unassigned
• Reporter: Ted Yu
• Created: 06/Jan/17 05:49
• Updated: 10/Jan/17 14:15
• Resolved: 10/Jan/17 14:15

Description

Here is related code:

    public R get() {
      if (super.size() < maxSize) {
        return null;
      }
      nextResource %= super.size();

Since super.size() is involved in modulo operation after the check, it seems the check should compare against 0 instead of maxSize.

Looks like a copy-paste error from put() method.

Issue Links

• links to: Review Board (master)