[HBASE-17258] MultiByteBuff#getXXX() has issues

• Type: Bug
• Status: Patch Available
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 2.0.0
• Assignee: ramkrishna.s.vasudevan
• Reporter: ramkrishna.s.vasudevan
• Created: 05/Dec/16 09:48
• Updated: 05/Dec/16 11:51

Description

MBB#getInt() - the relative getXXX() API has issues.

int remaining = this.curItem.remaining();
    if (remaining >= Bytes.SIZEOF_INT) {
      return this.curItem.getInt();
    }
    if (remaining == 0) {
      if (items.length - 1 == this.curItemIndex) {
        // means cur item is the last one and we wont be able to read a long. Throw exception
        throw new BufferUnderflowException();
      }
      this.curItemIndex++;
      this.curItem = this.items[this.curItemIndex];
      return this.curItem.getInt();
    }

Now here if the curItem does not have anything remaining in it we just go to the nextItem and from that we do a getInt. But we don't check if that item is big enough to return an int. This may not happen in most of the real cases but as an API it should handle that case. Since MBB are now used in the RpcServer#response there could be some on demand BB created that are smaller in sizes and it could lead to issues.