[HBASE-17064] Add TaskMonitor#getTasks() variant which accepts type selection

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.0.0-alpha-2, 2.0.0
• Labels: ui
• Hadoop Flags: Reviewed
• Assignee: Reid Chan
• Reporter: Ted Yu
• Created: 10/Nov/16 17:32
• Updated: 21/Mar/18 22:08
• Resolved: 15/Aug/17 16:46

Description

In TaskMonitorTmpl.jamon :

List<? extends MonitoredTask> tasks = taskMonitor.getTasks();
Iterator<? extends MonitoredTask> iter = tasks.iterator();
// apply requested filter
while (iter.hasNext()) {
  MonitoredTask t = iter.next();
  if (filter.equals("general")) {
    if (t instanceof MonitoredRPCHandler)
      iter.remove();

This means when user refreshes rs-status page, regardless of the type of filter, we always traverse and clone MonitoredTask's.

getTasks() is synchronized :

  public synchronized List<MonitoredTask> getTasks() {

A variant of getTasks() can be added which takes the type of filter so that unnecessary cloning is avoided.