[HBASE-16771] VerifyReplication should increase GOODROWS counter if re-comparison passes

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0, 2.0.0
• Hadoop Flags: Reviewed
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 05/Oct/16 16:04
• Updated: 10/Oct/16 08:03
• Resolved: 10/Oct/16 03:51

Description

HBASE-16423 added re-comparison feature to reduce false positive rate.

However, before logFailRowAndIncreaseCounter() is called, GOODROWS counter is not incremented. Neither is GOODROWS incremented when re-comparison passes.

This may produce inconsistent results across multiple runs of the same verifyrep command.