Details
-
Sub-task
-
Status: Closed
-
Major
-
Resolution: Fixed
-
2.0.0
-
None
-
Reviewed
Description
This is an issue when L1 and L2 cache used with combinedMode = false.
See in getBlock
if (victimHandler != null && !repeat) { Cacheable result = victimHandler.getBlock(cacheKey, caching, repeat, updateCacheMetrics); // Promote this to L1. if (result != null && caching) { cacheBlock(cacheKey, result, /* inMemory = */ false, /* cacheData = */ true); } return result; }
When block is not there in L1 and have it in L2, we will return the block read from L2 and promote that block to L1 by adding it in LRUCache. But if the Block buffer is having shared memory (Off heap bucket cache for eg , we can not directly cache this block. The buffer memory area under this block can get cleaned up at any time. So we may get block data corruption.
In such a case, we need to do a deep copy of the block (Including its buffer) and then add that to L1 cache.