[HBASE-15598] Potential null deference in CloneSnapshotProcedure#preCloneSnapshot()

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Assignee: Ted Yu
• Reporter: Ted Yu
• Created: 06/Apr/16 21:44
• Updated: 19/Aug/16 17:17
• Resolved: 19/Aug/16 17:17

Description

In CloneSnapshotProcedure#preCloneSnapshot():

      ProcedureSyncWait.getMasterQuotaManager(env)
        .checkNamespaceTableAndRegionQuota(getTableName(), manifest.getRegionManifestsMap().size());

Here is related code in SnapshotManifest#getRegionManifestsMap() :

    if (regionManifests == null || regionManifests.size() == 0) return null;
...

When there is no region manifest, null would be returned, resulting in NPE in CloneSnapshotProcedure#preCloneSnapshot()