Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-14703

HTable.mutateRow does not collect stats

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 1.3.0, 2.0.0
    • Client
    • None
    • Reviewed

    Description

      We are trying to fix the stats implementation, by moving it out of the Result object and into an Rpc payload (but not the 'cell payload', just as part of the values returned from the request). This change will also us use easily switch to AsyncProcess as the executor, and support stats, for nearly all the rpc calls. However, that means when you upgrade the client or server, you will lose stats visibility until the other side is upgraded. We could keep around the Result based stats storage to accommodate the old api and send both stats back from the server (in each result and in the rpc payload).
      Note that we will still be wire compatible - protobufs mean we can just ride over the lack of information.
      The other tricky part of this is that Result has a non-InterfaceAudience.Private getStatistics() method (along with two InterfaceAudience.Private addResults and setStatistics methods), so we might need a release to deprecate the getStats() method before throwing it out?

      Attachments

        1. HBASE-14703-v6_with-check-and-mutate.patch
          8 kB
          Jesse Yates
        2. HBASE-14703-v4.patch
          29 kB
          Jesse Yates
        3. HBASE-14703-v4.1.patch
          30 kB
          Jesse Yates
        4. HBASE-14703-start.patch
          4 kB
          Jesse Yates
        5. HBASE-14703-branch-1.v1.patch
          143 kB
          Heng Chen
        6. HBASE-14703-branch-1.patch
          142 kB
          Heng Chen
        7. HBASE-14703-branch-1_v1.patch
          143 kB
          Heng Chen
        8. HBASE-14703-async.patch
          4 kB
          Heng Chen
        9. HBASE-14703-5.2-addendum.patch
          105 kB
          Jesse Yates
        10. HBASE-14703.patch
          5 kB
          Heng Chen
        11. HBASE-14703_v9.patch
          147 kB
          Heng Chen
        12. HBASE-14703_v8.patch
          164 kB
          Heng Chen
        13. HBASE-14703_v7.patch
          141 kB
          Heng Chen
        14. HBASE-14703_v6-addendum.patch
          41 kB
          Heng Chen
        15. HBASE-14703_v6.patch
          140 kB
          Heng Chen
        16. HBASE-14703_v5.patch
          32 kB
          Heng Chen
        17. HBASE-14703_v5.2.patch
          34 kB
          Heng Chen
        18. HBASE-14703_v5.1.patch
          33 kB
          Heng Chen
        19. HBASE-14703_v3.patch
          15 kB
          Heng Chen
        20. HBASE-14703_v2.patch
          19 kB
          Heng Chen
        21. HBASE-14703_v13.patch
          146 kB
          Heng Chen
        22. HBASE-14703_v12.patch
          146 kB
          Heng Chen
        23. HBASE-14703_v11.patch
          146 kB
          Heng Chen
        24. HBASE-14703_v10.patch
          148 kB
          Heng Chen
        25. HBASE-14703_v10.patch
          148 kB
          Heng Chen
        26. HBASE-14703_v1.patch
          5 kB
          Heng Chen
        27. HBASE-14702_v5.2_addendum-addendum.patch
          9 kB
          Heng Chen

        Issue Links

          Activity

            People

              chenheng Heng Chen
              chenheng Heng Chen
              Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: