Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-14524

Short-circuit comparison of rows in CellComparator

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 2.0.0
    • Performance, Scanners
    • None
    • Reviewed

    Description

      CellComparator#compareRows compares two rows. For Scans and Gets these objects can sometimes be exactly the same object.

      I see this (without fully understanding everything that's going on) for the first cell in each row.

      In these circumstances I think it makes sense to short-circuit the comparison (not do a byte comparison and class cast checks) and bail out early if the objects are identical.

      Attachments

        1. HBASE-14524.patch
          1 kB
          Lars Francke
        2. HBASE-14524.patch
          1 kB
          Michael Stack
        3. HBASE-14524.patch
          0.9 kB
          Anoop Sam John

        Activity

          People

            larsfrancke Lars Francke
            larsfrancke Lars Francke
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: