[HBASE-14485] ConnectionImplementation leaks on construction failure

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.2.0, 1.0.1.1, 1.1.2, 1.3.0, 2.0.0
• Fix Version/s: 1.3.0, 2.0.0
• Component/s: Client
• Assignee: Matteo Bertozzi
• Reporter: Matteo Bertozzi
• Created: 24/Sep/15 22:19
• Updated: 01/Jul/22 21:34
• Resolved: 20/Jun/16 19:31

Description

If an exception is thrown in the constructor of ConnectionImplementation we will have a leak zkRegistry, rpcClient, ...

an example was clusterId parse error, causing zk (registry) leaks

org.apache.hadoop.hbase.client.ConnectionFactory.createConnection(ConnectionFactory.java:238)
	... 22 more
Caused by: java.lang.ExceptionInInitializerError
	at org.apache.hadoop.hbase.ClusterId.parseFrom(ClusterId.java:64)
	at org.apache.hadoop.hbase.zookeeper.ZKClusterId.readClusterIdZNode(ZKClusterId.java:75)
	at org.apache.hadoop.hbase.client.ZooKeeperRegistry.getClusterId(ZooKeeperRegistry.java:86)
	at org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.retrieveClusterId(ConnectionManager.java:850)