[HBASE-14372] test-patch doesn't properly account for flakey tests

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Component/s: build
• Assignee: Unassigned
• Reporter: Sean Busbey
• Created: 05/Sep/15 22:17
• Updated: 01/Jul/22 21:14
• Resolved: 25/Jul/19 17:39

Description

we use the surefire plugin to rerun failing tests to check for flakeys. if a flakey test fails once and then succeeds we get a vote that looks like this:

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

(note the lack of any listed tests)

looking back at the actual run we can see:

Flaked tests: 
org.apache.hadoop.hbase.util.TestHBaseFsck.testSplitDaughtersNotInMeta(org.apache.hadoop.hbase.util.TestHBaseFsck)
  Run 1: TestHBaseFsck.testSplitDaughtersNotInMeta:1771 null
  Run 2: PASS


Tests run: 2642, Failures: 0, Errors: 0, Skipped: 17, Flakes: 1