[HBASE-13881] Bug in HTable#incrementColumnValue implementation

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.98.6.1, 1.0.1
• Fix Version/s: 0.98.14, 1.0.2, 1.2.0, 1.1.2, 1.3.0
• Component/s: Client
• Hadoop Flags: Reviewed
• Release Note: HBASE-13881 Correct HTable incrementColumnValue implementation
• Assignee: Gabor Liptak
• Reporter: Jerry Lam
• Created: 10/Jun/15 00:31
• Updated: 31/Aug/15 22:39
• Resolved: 21/Jul/15 09:43

Description

The exact method I'm talking about is:

@Deprecated
  @Override
  public long incrementColumnValue(final byte [] row, final byte [] family,
      final byte [] qualifier, final long amount, final boolean writeToWAL)
  throws IOException {
    return incrementColumnValue(row, family, qualifier, amount,
      writeToWAL? Durability.SKIP_WAL: Durability.USE_DEFAULT);
  }

Setting writeToWAL to true, Durability will be set to SKIP_WAL which does not make much sense unless the meaning of SKIP_WAL is negated.