[HBASE-13606] AssignmentManager.assign() is not sync in both path

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.1.0, 1.2.0, 2.0.0
• Fix Version/s: 1.2.0, 1.1.1, 2.0.0
• Component/s: Region Assignment
• Assignee: Matteo Bertozzi
• Reporter: Matteo Bertozzi
• Created: 01/May/15 07:44
• Updated: 24/Jun/22 18:46
• Resolved: 11/May/15 23:18

Description

from the comment and the expected behavior AssignmentManager.assign() should be sync

/** Assigns specified regions round robin, if any.
 * This is a synchronous call and will return once every region has been
public void assign(List<HRegionInfo> regions)

but the code has two path. 1 sync and the async

if (servers == 1 || (regions < bulkAssignThresholdRegions
        && servers < bulkAssignThresholdServers)) {
   for (HRegionInfo region: plan.getValue()) {
     ...
        invokeAssign(region);  // <-- this is async threadPool.submit(assign)
     ...
  }
} else {
  BulkAssigner ba = new GeneralBulkAssigner(...);
  ba.bulkAssign();  // <-- this is sync, calls BulkAssign.waitUntilDone()
}

https://builds.apache.org/job/HBase-1.1/452/ TestCreateTableProcedure is flaky because of this async behavior