Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-13286

Minimum timeout for a rpc call could be 1 ms instead of 2 seconds

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 1.0.0, 0.98.12
    • 2.0.0
    • Client
    • None
    • Reviewed

    Description

      There is a check in the client to be sure that we don't use a timeout of zero (i.e. infinite). This includes setting the minimal time out for a rpc timeout to 2 seconds. However, it makes sense for some calls (typically gets going to the cache) to have much lower timeouts. So it's better to do the check vs. zero but with a minimal timeout of 1.

      I fixed a typo & a wrong comment in this patch as well. I don't understand this code:

            // t could be a RemoteException so go around again.
            translateException(t); // We don't use the result?
      

      but may be it's good.

      Attachments

        1. 13286.patch
          2 kB
          Nicolas Liochon

        Activity

          People

            nkeywal Nicolas Liochon
            nkeywal Nicolas Liochon
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: