[HBASE-13085] Security issue in the implementation of Rest gataway 'doAs' proxy user support

• Type: Bug
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 1.0.0, 0.98.10, 2.0.0
• Fix Version/s: 1.0.1, 1.1.0, 0.98.11, 2.0.0
• Component/s: REST, security
• Hadoop Flags: Reviewed
• Assignee: Jerry He
• Reporter: Jerry He
• Created: 23/Feb/15 21:53
• Updated: 11/Oct/15 02:17
• Resolved: 24/Feb/15 21:27

Description

When 'hbase.rest.support.proxyuser' is turned on, HBase Rest gateway support 'doAs' proxy user from the Rest client.

The current implementation checks to see if the 'rest server user' is authorized to impersonate the 'doAs' user (the user in the 'doAs' Rest query string).

if (doAsUserFromQuery != null) {
      Configuration conf = servlet.getConfiguration();
      if (!servlet.supportsProxyuser()) {
        throw new ServletException("Support for proxyuser is not configured");
      }
      UserGroupInformation ugi = servlet.getRealUser();
      // create and attempt to authorize a proxy user (the client is attempting
      // to do proxy user)
      ugi = UserGroupInformation.createProxyUser(doAsUserFromQuery, ugi);
      // validate the proxy user authorization
      try {
        ProxyUsers.authorize(ugi, request.getRemoteAddr(), conf);
      } catch(AuthorizationException e) {
        throw new ServletException(e.getMessage());
      }
      servlet.setEffectiveUser(doAsUserFromQuery);
    } 

The current implementation allows anyone from the rest client side to impersonate another user by 'doAs'.
For example, potentially, 'user1' can 'doAs=admin'

The correct implementation should check to see if the rest client user is authorized to do impersonation.

Issue Links

• relates to: HBASE-13116 Enhance the documentation for usage of "doAs" through REST and Thrift gateways
• relates to: HBASE-13115 Fix the usage of remote user in thrift doAs implementation.