[HBASE-12979] Use setters instead of return values for handing back statistics from HRegion methods

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.98.10
• Fix Version/s: 1.0.0, 1.1.0, 0.98.11, 0.98.10.1
• Labels: phoenix
• Assignee: Jesse Yates
• Reporter: Andrew Kyle Purtell
• Created: 05/Feb/15 21:33
• Updated: 06/Apr/18 17:54
• Resolved: 08/Feb/15 17:40

Description

In HBASE-5162 (and backports such as HBASE-12729) we modified some HRegion methods to return statistics for consumption by callers. The statistics are ultimately passed back to the client as load feedback.

lhofhansl thinks handing back this information as return values from HRegion methods is a weird mix of concerns. This also produced a difficult to anticipate binary compatibility issue with Phoenix. There was no compile time issue because the code of course was not structured to assign from a method returning void, yet the method signature changes so the JVM cannot resolve it if older Phoenix binaries are installed into a 0.98.10 release. Let's change the HRegion methods back to returning 'void' and use setters instead. Officially we don't support use of HRegion (HBASE-12566) but we do not need to go out of our way to break things (smile) so I would also like to make a patch release containing just this change to help out our sister project.