Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-11745

FilterAllFilter should return ReturnCode.SKIP

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.99.0, 0.98.6
    • None
    • None
    • Reviewed

    Description

      FilterAllFilter is a filter in hbase-server's test packages used by PerformanceEvaluation to filter all results at the server when given the --filterAll command line argument. There is an unfortunate bug in versions greater than 0.94 (where I rewrote this filter and didn't notice the issue in later versions at the time):

        @Override
        public ReturnCode filterKeyValue(Cell v) throws IOException {
          return ReturnCode.INCLUDE;
        }
      

      This is obviously wrong, and results in the creation of KeyValue objects that we will almost immediately throw away when processing filterRow for backwards compatibility, which FilterAllFilter implements as:

        @Override
        public boolean filterRow() throws IOException {
          return true;
        }
      

      We noticed this problem when comparing object allocations during RPC processing between 0.94 and 0.98.

      Attachments

        1. HBASE-11745.patch
          2 kB
          Andrew Kyle Purtell
        2. HBASE-11745_v3.patch
          2 kB
          Andrew Kyle Purtell
        3. HBASE-11745_v2.patch
          2 kB
          Andrew Kyle Purtell

        Activity

          People

            apurtell Andrew Kyle Purtell
            apurtell Andrew Kyle Purtell
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: