[HBASE-11623] mutateRowsWithLocks might require updatesLock.readLock with waitTime=0

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.96.1.1, 0.94.21, 0.98.4
• Fix Version/s: 0.99.0, 0.98.5, 0.94.22
• Component/s: regionserver
• Hadoop Flags: Reviewed
• Assignee: Jianwei Cui
• Reporter: Jianwei Cui
• Created: 31/Jul/14 04:50
• Updated: 04/Apr/18 23:05
• Resolved: 31/Jul/14 23:55

Description

mutateRowsWithLocks will acquire updatesLock.readLock by the following code:

...
lock(this.updatesLock.readLock(), acquiredRowLocks.size());
...

However, acquiredRowLocks might be empty, and then the waitTime of HRegion.lock(...) will be set to 0, which will make mutateRowsWithLocks fail if can not acquire updatesLock.readLock immediately.
In our environment, we implement a region coprocessor which need to hold row locks before invoke mutateRowsWithLocks. Then, the rowsToLock(passed to mutateRowsWithLocks) will be an empty set, and we get the following exception occasionally:

org.apache.hadoop.hbase.RegionTooBusyException: failed to get a lock in 0ms                                                                                          
 582   at org.apache.hadoop.hbase.regionserver.HRegion.lock(HRegion.java:6191)
 583   at org.apache.hadoop.hbase.regionserver.HRegion.mutateRowsWithLocks(HRegion.java:5126)
 584   at org.apache.hadoop.hbase.regionserver.HRegion.mutateRowsWithLocks(HRegion.java:5034)
...

Is it reasonable that we use default waitTime when rowsToLock is empty? (as the following code)

lock(this.updatesLock.readLock(), acquiredRowLocks.size() == 0 ? 1 : acquiredRowLocks.size());