[HBASE-11308] Reuse NameStringPair#Builder instances in loops

• Type: Task
• Status: Closed
• Priority: Trivial
• Resolution: Won't Fix
• Assignee: Unassigned
• Reporter: Ted Yu
• Created: 07/Jun/14 20:24
• Updated: 17/Jun/22 05:52
• Resolved: 08/Jun/14 18:16

Description

The following code is from HColumnDescriptor#convert() but the pattern can be found in other classes, such as HBaseAdmin:

    for (Map.Entry<String, String> e : this.configuration.entrySet()) {
      NameStringPair.Builder aBuilder = NameStringPair.newBuilder();
      aBuilder.setName(e.getKey());
      aBuilder.setValue(e.getValue());
      builder.addConfiguration(aBuilder.build());
    }

NameStringPair.Builder instance can be reused across iterations of the loop.
This would save creation of short-lived objects.