[HBASE-11041] HBaseTestingUtil.createMultiRegions deals incorrectly with missing column family

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Cannot Reproduce
• Assignee: Unassigned
• Reporter: Lars Hofhansl
• Created: 20/Apr/14 16:57
• Updated: 17/Jun/22 05:33
• Resolved: 13/May/14 06:18

Description

Just found a test failing like this:

Error Message

HTableDescriptor is read-only

Stacktrace

java.lang.UnsupportedOperationException: HTableDescriptor is read-only
	at org.apache.hadoop.hbase.client.UnmodifyableHTableDescriptor.addFamily(UnmodifyableHTableDescriptor.java:64)
	at org.apache.hadoop.hbase.HBaseTestingUtility.createMultiRegions(HBaseTestingUtility.java:1302)
	at org.apache.hadoop.hbase.HBaseTestingUtility.createMultiRegions(HBaseTestingUtility.java:1291)
	at org.apache.hadoop.hbase.HBaseTestingUtility.createMultiRegions(HBaseTestingUtility.java:1286)
	at org.apache.hadoop.hbase.master.TestDistributedLogSplitting.installTable(TestDistributedLogSplitting.java:485)
	at org.apache.hadoop.hbase.master.TestDistributedLogSplitting.testMasterStartsUpWithLogSplittingWork(TestDistributedLogSplitting.java:282)

The code that causes this looks like this:

    HTableDescriptor htd = table.getTableDescriptor();
    if(!htd.hasFamily(columnFamily)) {
      HColumnDescriptor hcd = new HColumnDescriptor(columnFamily);
      htd.addFamily(hcd);
    }

But note that table.getTableDescriptor() returns an UnmodifyableHTableDescriptor, so the add would always fail.

The specific test that failed was TestDistributedLogSplitting.testMasterStartsUpWithLogSplittingWork.
Looks like the HMaster did not have the last table descriptor state, yet.