[HBASE-10627] A logic mistake in HRegionServer isHealthy

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.96.2, 0.98.1, 0.99.0, 0.94.18
• Hadoop Flags: Reviewed
• Assignee: Shaohui Liu
• Reporter: Shaohui Liu
• Created: 27/Feb/14 08:23
• Updated: 14/Aug/14 20:20
• Resolved: 28/Feb/14 17:35

Description

After visiting the isHealthy in HRegionServer, I think there is a logic mistake.

    // Verify that all threads are alive
    if (!(leases.isAlive()
        && cacheFlusher.isAlive() && hlogRoller.isAlive()
        && this.compactionChecker.isAlive())   <---- logic wrong here
        && this.periodicFlusher.isAlive()) {
      stop("One or more threads are no longer alive -- stop");
      return false;
    }

which should be

    // Verify that all threads are alive
    if (!(leases.isAlive()
        && cacheFlusher.isAlive() && hlogRoller.isAlive()
        && this.compactionChecker.isAlive()
        && this.periodicFlusher.isAlive())) {
      stop("One or more threads are no longer alive -- stop");
      return false;
    }

Please finger out if i am wrong. Thx