Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-10604

Fix parseArgs javadoc

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.96.2, 0.98.1, 0.99.0
    • None
    • None
    • Reviewed

    Description

      Javadoc for parseArgs is a cut&past of previous method and need to be fixed.

        /*
         * Adds a region's meta information from the passed <code>meta</code>
         * region.
         *
         * @param metainfo hbase:meta HRegionInfo to be updated
         * @param region HRegion to add to <code>meta</code>
         *
         * @throws IOException
         */
        private int parseArgs(String[] args) throws IOException {
          GenericOptionsParser parser =
            new GenericOptionsParser(getConf(), args);
      
          String[] remainingArgs = parser.getRemainingArgs();
          if (remainingArgs.length != 3) {
            usage();
            return -1;
          }
          tableName = TableName.valueOf(remainingArgs[0]);
      
          region1 = Bytes.toBytesBinary(remainingArgs[1]);
          region2 = Bytes.toBytesBinary(remainingArgs[2]);
          int status = 0;
          if (notInTable(tableName, region1) || notInTable(tableName, region2)) {
            status = -1;
          } else if (Bytes.equals(region1, region2)) {
            LOG.error("Can't merge a region with itself");
            status = -1;
          }
          return status;
        }
      

      Attachments

        1. HBASE-10604-v0-trunk.patch
          0.7 kB
          Jean-Marc Spaggiari

        Activity

          People

            jmspaggi Jean-Marc Spaggiari
            jmspaggi Jean-Marc Spaggiari
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: