Details
-
Test
-
Status: Closed
-
Major
-
Resolution: Fixed
-
None
-
None
-
None
-
None
-
Reviewed
Description
Here is related code in the script:
MAX_LINE_LENGTH_PATCH=`expr $MAX_LINE_LENGTH + 1` ... ll=`echo "$lines" | wc -l` if [[ "$ll" -gt "$MAX_LINE_LENGTH_PATCH" ]]; then
Here was the result from dry run:
TYus-MacBook-Pro:m7 tyu$ lines=`cat ~/trunk/7226-trunk.patch | grep "^+" | grep -v "^@@" | grep -v "^+++" | grep -v "import" | grep -v "hbase.protobuf.generated" | awk -v len="101" 'length ($0) > len' | head -n 10` TYus-MacBook-Pro:m7 tyu$ ll=`echo "$lines" | wc -l` TYus-MacBook-Pro:m7 tyu$ echo $ll 3 TYus-MacBook-Pro:m7 tyu$ echo $lines + // Test CompareOp.LESS_OR_EQUAL: original = val2, compare with val2, succeed (value still = val2) + // Test CompareOp.LESS_OR_EQUAL: original = val2, compare with val1, succeed (now value = val3) + // Test CompareOp.GREATER_OR_EQUAL: original = val2, compare with val2, succeed (value still = val2)
The value of $ll should be compared with 0, not the value of $MAX_LINE_LENGTH_PATCH