[classlib] [security] UnresolvedPermission.equals(Object) doesn't works well

• Key: HARMONY-6043
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Tony Wu
• Reporter: Kevin Zhou
• Component/s: Classlib
• Affects Version/s: 5.0M8
• Fix Version/s: 5.0M9

Description

Given a test case[1], RI works well while HARMONY fails.

[1] UnresolvedPermissionTest
public class UnresolvedPermissionTest extends TestCase {
    public static final String type = "java.util.PropertyPermission";
    public static final String name = "os.name";
    public static final String action = "write,read";
    public void test_Scenario0() {
        UnresolvedPermission up1 = new UnresolvedPermission(type, name, action,
                null);
        UnresolvedPermission up2 = new UnresolvedPermission(type, name, action,
                null);
        assertEquals(up1, up2);
    }

    public void test_Scenario1() {
        UnresolvedPermission up1 = new UnresolvedPermission(type, name, action,
                null);
        UnresolvedPermission up2 = new UnresolvedPermission(type, name, action,
                new java.security.cert.Certificate[0]);
        assertFalse(up1.equals(up2));
    }

    public void test_Scenario2() {
        UnresolvedPermission up1 = new UnresolvedPermission(type, name, action,
                null);
        UnresolvedPermission up2 = new UnresolvedPermission(type, name, action,
                new java.security.cert.Certificate[2]);
        assertFalse(up1.equals(up2));
    }

    public void test_Scenario3() {
        UnresolvedPermission up1 = new UnresolvedPermission(type, name, action,
                new java.security.cert.Certificate[0]);
        UnresolvedPermission up2 = new UnresolvedPermission(type, name, action,
                new java.security.cert.Certificate[0]);
        assertEquals(up1, up2);
    }

    public void test_Scenario4() {
        UnresolvedPermission up1 = new UnresolvedPermission(type, name, action,
                new java.security.cert.Certificate[0]);
        UnresolvedPermission up2 = new UnresolvedPermission(type, name, action,
                new java.security.cert.Certificate[2]);
        assertFalse(up1.equals(up2));
    }

    public void test_Scenario5() {
        UnresolvedPermission up1 = new UnresolvedPermission(type, name, action,
                new java.security.cert.Certificate[2]);
        UnresolvedPermission up2 = new UnresolvedPermission(type, name, action,
                new java.security.cert.Certificate[2]);
        try {
            up1.equals(up2);
            fail("should throw NullPointerException");
        } catch (NullPointerException e) {
            // Expected
        }
    }

    public void test_Scenario6() {
        UnresolvedPermission up1 = new UnresolvedPermission(type, name, action,
                new java.security.cert.Certificate[2]);
        UnresolvedPermission up2 = new UnresolvedPermission(type, name, action,
                new java.security.cert.Certificate[5]);
        assertFalse(up1.equals(up2));
    }
}

Comments

[Kevin Zhou]

Would you please help to try it?

[Kevin Zhou]

It seems that Harmony's behavior is different from RI.
Already make a patch attached.

[Kevin Zhou]

Patch applied to r725920.

[Alexey Varlamov]

Guys, the patch is not really good.. One must make defensive copy when setting array properties - plain assigment of array reference is unsafe.

Also, it is not really clear from the report what the problem is? I have no Harmony build at hand nor RI 1.6 nearby, could you please cite console logs for the both runtimes?

[Alexey Varlamov]

Looking on the test source, I'd rather consider this as non-bug difference.
Especially, test_Scenario5 vs test_Scenario6 is a true find - do we really have to comply?

[Kevin Zhou]

Would you please help to try it?

[Tony Wu]

2nd patch applied at r728589 with handling to NPE. Thanks Kevin. Please verify if it fixes as you expected.