Details
-
Bug
-
Status: Resolved
-
Major
-
Resolution: Invalid
-
None
-
None
-
None
-
None
Description
HADOOP-9112 enables the function of marking -1 when the newly added tests don't have timeout. However, test-patch will mark -1 due to a context @Test by mistake. Bellow is the problematic part of the YARN-378_3.patch that I've created.
+ } + } + @Test public void testRMAppSubmitWithQueueAndName() throws Exception { long now = System.currentTimeMillis();
There's a @Test without timeout (most existing tests don't have timeout) in the context. In test-patch, $AWK '{ printf "%s ", $0 }' collapses these lines into one line, i.e.,
+ } + } + @Test public void testRMAppSubmitWithQueueAndName() throws Exception { long now = System.currentTimeMillis();
Then, @Test in the context follows a "+", and is regarded as a newly added test by mistake. Consequently, the following regex will accept the context @Test.
Attachments
Attachments
Issue Links
- is broken by
-
HADOOP-12439 test-patch should -1 for @Tests without a timeout
- Reopened