[HADOOP-9227] FileSystemContractBaseTest doesn't test filesystem's mkdir/isDirectory() logic rigorously enough

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha1
• Fix Version/s: 2.1.0-beta
• Component/s: fs
• Release Note: fixed in HADOOP-9258
• Assignee: Steve Loughran
• Reporter: Steve Loughran
• Created: 18/Jan/13 14:23
• Updated: 18/Aug/16 18:35
• Resolved: 25/Mar/13 13:15

Description

The FileSystemContractBaseTest.mkdirs() asserts that a newly created directory is true, but way of FileStatus.isFile(), but doesn't assert that the directory is a dir by way of FileStatus.isDir().

The assertion used is slightly weaker, as the isFile() test is actually
!isdir && !isSymlink(). if an implementation of FileSystem.mkdirs() created symlinks then the test would still pass.

There is one test that looks at the isDirectory() logic, testMkdirsWithUmask() -but as that test is skipped for the s3 filesystems, it is possible for those filesystems (or similar) to not have their directory creation logic stressed enough.

The fix would be a trivial single line.

Issue Links

• Is contained by: HADOOP-9258 Add stricter tests to FileSystemContractTestBase
• is related to: HADOOP-13518 backport HADOOP-9258 to branch-2