Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-9104

Should org.apache.hadoop.fs.DelegationTokenRenewer.addRenewAction(T) reject addition if a renew action for this FS is already present in the queue?

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • None
    • None

    Description

      The issue extracted from discussion in https://issues.apache.org/jira/browse/HADOOP-9046 .

      Currently the method org.apache.hadoop.fs.DelegationTokenRenewer.addRenewAction(T) allows to add any number of renew actions for the same FS.
      Question #1: are there real use-cases when that makes sense?

      Also, when we remove a renew action with org.apache.hadoop.fs.DelegationTokenRenewer.removeRenewAction(T), we iterate over all the actions in the queue, and remove the first one with matching FS, if any. So, in case if several actions submitted for the same FS, not more than one action will be removed upon #removeRenewAction() invocation. So, to remove all them for a given FS, a developer will need a cycle. So, if the answer to the question #1 is true, may be we should change the #removeRenewAction(FS) behavior to remove all actions associated with this FS, or add #removeAllRenewActuions(FS)? This is question #2.

      Attachments

        Activity

          People

            Unassigned Unassigned
            iveselovsky Ivan A. Veselovsky
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated: