Uploaded image for project: 'Hadoop Common'
  1. Hadoop Common
  2. HADOOP-8451

slightly inconsistent file names for native code

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Trivial
    • Resolution: Unresolved
    • None
    • None
    • None
    • None

    Description

      During HADOOP-8368, someone pointed out that it would be nice for the C/C++ files to be in directories named 'native'. However, this is currently not the case.

      Some examples:
      [from hadoop-common]

      ./test/system/c++/runAs/main.c
      ./test/system/c++/runAs/runAs.c
      ./main/native/src/org/apache/hadoop/util/NativeCrc32.c
      ./main/native/src/org/apache/hadoop/util/bulk_crc32.c
      ...etc..
      

      From hadoop-hdfs:

      ./hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_readdir.c
      ./hadoop-hdfs/src/contrib/fuse-dfs/src/fuse_impls_utimens.c
      ./hadoop-hdfs/src/main/native/hdfs_read.c
      ./hadoop-hdfs/src/main/native/hdfs.c
      ... etc...
      

      From hadoop-mapreduce-project:

      ./hadoop-mapreduce-project/src/examples/pipes/impl/wordcount-simple.cc
      ./hadoop-mapreduce-project/src/examples/pipes/impl/wordcount-part.cc
      ./hadoop-mapreduce-project/src/c++/utils/impl/StringUtils.cc
      ./hadoop-mapreduce-project/src/c++/utils/impl/SerialUtils.cc
      ./hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/test/test-container-executor.c
      ./hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/native/container-executor/impl/main.c
      ... etc...
      

      There's probably a little more we could do to tidy this up... at minimum, pick one of 'c++' or 'native' and use it consistently. So this JIRA is a reminder.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              cmccabe Colin McCabe
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated: