Unit tests for FileSystemContextUtil.

• Key: HADOOP-6260
• Type: Test
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: gary murry
• Reporter: gary murry
• Component/s: fs
• Affects Version/s: 0.21.0
• Fix Version/s: 0.21.0

Description

This Jira is to add the unit tests associated with HADOOP-4952.

Comments

[Suresh Srinivas]

Comments:

1. Some new classes are missing the banner
2. Add a comment to the class to briefly describe what the test is doing
3. Use log instead of system.out.println

[gary murry]

Attached a new patch I believe addresses Suresh's comments.

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12420094/HADOOP-6260.patch
against trunk revision 816794.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 97 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/11/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/11/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/11/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/11/console

This message is automatically generated.

[gary murry]

The previous patch passed on windows but was killing Hudson. I changed "/test/..." to "test/..."

[Konstantin Boudnik]

few comments:

• lot of duplicated string literals. Move them to be the class' member or something. It also will make assertion structure smaller and easier to read (see my comment to HADOOP-6261
• in the messages like Can't run test it makes sense to add test name - makes it easier to analyze
• catch and finally are suppose to start next to the closing curve bracket (in the same line, not in the next one)

Other than that it seems pretty good I think!

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12420103/HADOOP-6260.patch
against trunk revision 816794.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 15 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/13/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/13/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/13/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h1.grid.sp2.yahoo.net/13/console

This message is automatically generated.

[gary murry]

This patch addresses cos's comments.

[Suresh Srinivas]

Attaching new patch that incorporates new recursive version of mkdir.

[Suresh Srinivas]

New patch that includes missing files

[Suresh Srinivas]

Hudson is stuck. Ran test manually. All tests pass.

[Jakob Homan]

test-patch is good:

     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 15 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.

[Suresh Srinivas]

Just committed the patch. Thanks Gary.

[Hudson]

Integrated in Hadoop-Common-trunk-Commit #45 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/45/)
. Add additional unit tests for FileContext util methods. Contributed by Gary Murray.

[Hudson]

Integrated in Hadoop-Common-trunk #102 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/102/)
. Add additional unit tests for FileContext util methods. Contributed by Gary Murray.