Changes in common to rename the config keys as detailed in HDFS-531.

• Key: HADOOP-6233
• Type: Improvement
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Jitendra Nath Pandey
• Reporter: Jitendra Nath Pandey
• Component/s: fs
• Affects Version/s: 0.21.0
• Fix Version/s: 0.21.0

Description

This jira tracks the code changes required in common to rename the config keys. The list of changed keys is attached to HDFS-531.

Comments

[Jitendra Nath Pandey]

The attached patch is created after merging the patch of HADOOP-6105.

[Jakob Homan]

Gave the patch a quick look-over:

• The patch has gone stale with the committing of HADOOP-6234. The config key umask has been changed to umaskmode and its type is now a string.
• I'm concerned about having all the key changes for all across the project clustered in one file, and more so that there's a separate file for just the fs. It seems to me this will lead to confusion about updating those values or adding new ones. Might it be better to include that info in the relevant file?
• In Configuration, the code readability could be improved with a private static function like addDepKey(keyName, keyValue) that handles all the boiler plate of Configuration.addDeprecation(*, new String[] { *} ).

[Tom White]

I think it would be good to explicitly put the word "default" in the variable names for the default values. E.g. IO_NATIVE_LIB_AVAILABLE_DEFAULT rather than IO_NATIVE_LIB_AVAILABLE. This would avoid any doubt to users that the value is the current value, for example.

[Jitendra Nath Pandey]

> I'm concerned about having all the key changes for all across the project clustered in one file, and more so that there's a separate file for just the fs. It seems to me this will lead to confusion about updating those values or adding new ones. Might it be better to include that info in the relevant file?

I think it will be better to have just one class having all the configuration keys for entire common project, i.e. we should merge fs keys and other common keys into one single file. In my opinion, it will be easier for the users and developers if there is a single place to look for config keys or to add new keys. Also, since we have common configuration files, it will be better to have a common place to hold the config keys too, like in src/java/org/apache/hadoop/conf/CommonConfigurationKeys.java.

[Jakob Homan]

+1 pending Hudson or unit tests/test patch.

[Hadoop QA]

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12420075/HADOOP-6233.8.patch
against trunk revision 816752.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 4 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/53/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/53/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/53/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/53/console

This message is automatically generated.

[Jakob Homan]

+1 for updated patch, v8

[Suresh Srinivas]

Just committed this change. Thanks Jitendra.

[Hudson]

Integrated in Hadoop-Common-trunk-Commit #44 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/44/)
. Rename configuration keys towards API standardization and backward compatibility. Contributed by Jithendra Pandey.

[Hudson]

Integrated in Hadoop-Common-trunk #102 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/102/)
. Rename configuration keys towards API standardization and backward compatibility. Contributed by Jithendra Pandey.

[Robert Chansler]

Editorial pass over all release notes prior to publication of 0.21. Subtask.