fix GenericOptionParser to deal with -D with '=' in the value

• Key: HADOOP-6215
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Amar Kamat
• Reporter: Owen O'Malley
• Fix Version/s: 0.20.1

Description

Currently the code ignores any -D option that has a "=" in the value. This is clearly wrong.
In particular, -Dx=y=z should work and assign "y=z" to "x". This is a regression from HADOOP-6213.

Comments

[Amar Kamat]

The patch in HADOOP-6213 makes GenericOptionsParser same as in commons-trunk. We can fix both here.

[Amar Kamat]

Attaching a patch for commons and branch 0.20. Testing in progress.

[Amar Kamat]

Result of test-patch
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

Ant tests passed on my box.

[Amar Kamat]

Testing on branch 20

[Amar Kamat]

All core tests except TestDistributedFileSystem and TestReduceFetch failed on core.
All contrib tests except TestStreamingExitStatus, TestJobInitialization and TestQueueCapacities passed.

[Sharad Agarwal]

+1 I committed to trunk and branch 20. Thanks Amar!

[Hudson]

Integrated in Hadoop-Common-trunk-Commit #2 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/2/)
. fix GenericOptionParser to deal with -D with '=' in the value. Contributed by Amar Kamat.

[Amar Kamat]

Note that this is not a regression caused because of HADOOP-6213. I tested the code pre-H6213 and found that "-D x=y=z" throws parse-exception.

[Hudson]

Integrated in Hadoop-Common-trunk #77 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/77/)
. fix GenericOptionParser to deal with -D with '=' in the value. Contributed by Amar Kamat.