[#HADOOP-6213] Remove commons dependency on commons-cli2

Hadoop Common

HADOOP-3676

Remove commons dependency on commons-cli2

Created: 26/Aug/09 06:33 AM Updated: 26/Aug/09 05:17 PM

Return to search

Component/s:

util

Affects Version/s:

0.20.0

Fix Version/s:

0.20.1

Time Tracking:

Not Specified

File Attachments:

	File Name	Date Attached	Attached By	Size
	HADOOP-6213-v1.0.patch	2009-08-26 09:13 AM	Amar Kamat	1 kB

Issue Links:

Blocker

This issue blocks:

~~HADOOP-3676~~ Remove Hadoop's dependance on the cli 2 snapshot

Reference

This issue relates to:

~~HADOOP-5896~~ Remove the dependency of GenericOptionsParser on Option.withArgPattern

Hadoop Flags:	Reviewed
Release Note:	« Hide GenericOptionsParser in branch 0.20 depends on commons-cli2. This jira removes the dependency of branch 0.20 on commons-cli2 completely. The problem is seen after 'ant binary' where all the library files are copied to '$hadoop-home/lib' which already has commons-cli2. Show » GenericOptionsParser in branch 0.20 depends on commons-cli2. This jira removes the dependency of branch 0.20 on commons-cli2 completely. The problem is seen after 'ant binary' where all the library files are copied to '$hadoop-home/lib' which already has commons-cli2.
Resolution Date:	26/Aug/09 03:17 PM

Description

« Hide

GenericOptionsParser depends on commons-cli2

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

[ Permlink | « Hide ]

Amar Kamat added a comment - 26/Aug/09 09:13 AM

Attaching a patch that removes the dependency on GenericOptionsParser on commons-cli2.
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] -1 Eclipse classpath. The patch causes the Eclipse classpath to differ from the contents of the lib directories.

Eclipse classpath check fails because commons-cli2 has to be manually deleted.

Running ant tests.