Correct info message "Use hadoop dfs -safemode option" to " Use hdfs dfsadmin -safemode option" .

• Key: HADOOP-5937
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Minor
• Assignee: Ravi Phulari
• Reporter: Ravi Phulari
• Affects Version/s: 0.20.0
• Fix Version/s: 0.20.1, 0.21.0

Description

Safemode error message

Use "hadoop dfs -safemode leave" to turn safe mode off.

should be corrected as

Use "hdfs dfsadmin -safemode leave" to turn safe mode off.

Comments

[Ravi Phulari]

No code changes made , only changes in information message .
No unit tests added as there are no addition or code changes .

[Jakob Homan]

+1. Looks good.

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12409333/HADOOP-5937.patch
against trunk revision 780114.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed core unit tests.

-1 contrib tests. The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/436/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/436/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/436/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/436/console

This message is automatically generated.

[Tsz Wo (Nicholas), SZE]

The failed tests are not related.

I have committed this. Thanks, Ravi!

[Ramya R]

I think the above patch should not be applied to branch 20 as bin/hdfs is supported only after the project split. Hence opened HADOOP:5990.

[Tsz Wo (Nicholas), SZE]

Ramya, you are right. 0.20 needs a different message. Thanks for looking at this. I will revert the patch committed to 0.20.

Ravi, could you post a new patch for 0.20?

[Ravi Phulari]

Thanks for correction Ramya , Nicholas please consider this patch for Hadoop 20 .

[Ravi Phulari]

Manually tested this patch on command line.

hoaxhost:branch-0.20 rphulari$ bin/hadoop dfsadmin -safemode enter
Safe mode is ON
hoaxhost:branch-0.20 rphulari$ bin/hadoop jar build/hadoop-0.20.1-dev-examples.jar wordcount dt op
org.apache.hadoop.ipc.RemoteException: org.apache.hadoop.hdfs.server.namenode.SafeModeException: Cannot delete /Users/rphulari/tmpForHadoop/hadoop-rphulari/mapred/system/job_200906081432_0002. Name node is in safe mode.
Use "hadoop dfsadmin -safemode leave" to turn safe mode off.
at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.deleteInternal(FSNamesystem.java:1679)
	at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.delete(FSNamesystem.java:1659)
	at org.apache.hadoop.hdfs.server.namenode.NameNode.delete(NameNode.java:517)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
        ....
hoaxhost:branch-0.20 rphulari$ bin/hadoop dfsadmin -safemode leave
Safe mode is OFF

[Tsz Wo (Nicholas), SZE]

I have committed the 0.20 patch. Thanks, Ravi!

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12410163/HADOOPv20-5937.patch
against trunk revision 782708.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.

-1 patch. The patch command could not apply the patch.

Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/482/console

This message is automatically generated.