Create public enum class for the Framework counters in org.apache.hadoop.mapreduce

• Key: HADOOP-5717
• Type: Improvement
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Amareshwari Sriramadasu
• Reporter: Owen O'Malley
• Fix Version/s: 0.21.0

Description

We need to make the counters from the framework visible, but they should be in the new package (org.apache.hadoop.mapreduce).

For compatibility, we need the old class of counters to recognize the old class and package names and convert them over to the new names.

Comments

[Amareshwari Sriramadasu]

Attaching patch for moving framework counters to public class in mapreduce package. and providing the support for old group names in Counters class.

[Amareshwari Sriramadasu]

All tests passed on my machine.
Existing unit tests in core test the new counters. contrib-tests test the deprecation for old group names.

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12406500/patch-5717.txt
against trunk revision 768376.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 21 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/251/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/251/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/251/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/251/console

This message is automatically generated.

[Amareshwari Sriramadasu]

Patch fixing the test failure.

[Hadoop QA]

+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12406596/patch-5717-1.txt
against trunk revision 769623.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 24 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

+1 core tests. The patch passed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/257/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/257/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/257/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/257/console

This message is automatically generated.

[Sharad Agarwal]

The resource bundle files - (Task_Counter.properties and JobInProgress_Counter.properties) should be renamed as per the new class names and moved to mapreduce package.

[Amareshwari Sriramadasu]

Patch incorporating review comments.

[Amareshwari Sriramadasu]

test-patch result:

     [exec]
     [exec] +1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 24 new or modified tests.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
     [exec]
 

[Amareshwari Sriramadasu]

All unit tests passed on my machine.

[Sharad Agarwal]

I just committed this. Thanks Amareshwari!

[Hudson]

Integrated in Hadoop-trunk #826 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/826/)
. Create public enum class for the Framework counters. Contributed by Amareshwari Sriramadasu.