Issue Details (XML | Word | Printable)

Key: HADOOP-5711
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Minor Minor
Assignee: Tsz Wo (Nicholas), SZE
Reporter: Tsz Wo (Nicholas), SZE
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Hadoop Common

Change Namenode file close log to info

Created: 21/Apr/09 05:44 PM   Updated: 08/Jul/09 04:43 PM
Return to search
Component/s: None
Affects Version/s: None
Fix Version/s: 0.20.1, 0.21.0

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works 5711_20090422.patch 2009-04-23 12:35 AM Tsz Wo (Nicholas), SZE 0.8 kB
Text File Licensed for inclusion in ASF works 5711_20090428.patch 2009-04-29 12:29 AM Tsz Wo (Nicholas), SZE 0.8 kB

Hadoop Flags: Reviewed
Resolution Date: 29/Apr/09 08:53 PM


 Description  « Hide
It is hard to tell whether a file is closed or not from the Namenode log if the stateChangeLog is not set to debug level. It is better to log file close in info level.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Tsz Wo (Nicholas), SZE added a comment - 23/Apr/09 12:35 AM
5711_20090422.patch: change log level

Tsz Wo (Nicholas), SZE made changes - 23/Apr/09 12:35 AM
Field Original Value New Value
Attachment 5711_20090422.patch [ 12406192 ]
Hairong Kuang added a comment - 28/Apr/09 11:46 PM
Maybe a more informative message is better, something like "file xx is closed by yy".

Tsz Wo (Nicholas), SZE added a comment - 29/Apr/09 12:29 AM
5711_20090428.patch: changed the message.

Tsz Wo (Nicholas), SZE made changes - 29/Apr/09 12:29 AM
Attachment 5711_20090428.patch [ 12406719 ]
Hairong Kuang added a comment - 29/Apr/09 05:43 PM
+1

Tsz Wo (Nicholas), SZE made changes - 29/Apr/09 05:49 PM
Assignee Tsz Wo (Nicholas), SZE [ szetszwo ]
Hadoop Flags [Reviewed]
Status Open [ 1 ] Patch Available [ 10002 ]
Tsz Wo (Nicholas), SZE added a comment - 29/Apr/09 08:44 PM
     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
     [exec]                         Please justify why no tests are needed for this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.

The change is trivial. Don't want to waste cycles in Hudson. Will commit it soon.


Repository Revision Date User Message
ASF #769923 Wed Apr 29 20:49:25 UTC 2009 szetszwo HADOOP-5711. Change Namenode file close log to info.
Files Changed
MODIFY /hadoop/core/trunk/CHANGES.txt
MODIFY /hadoop/core/trunk/src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java

Repository Revision Date User Message
ASF #769924 Wed Apr 29 20:49:36 UTC 2009 szetszwo HADOOP-5711. Change Namenode file close log to info.
Files Changed
MODIFY /hadoop/core/branches/branch-0.20/CHANGES.txt
MODIFY /hadoop/core/branches/branch-0.20/src/hdfs/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java

Tsz Wo (Nicholas), SZE added a comment - 29/Apr/09 08:53 PM
I have committed this to 0.20.1 and above.

Tsz Wo (Nicholas), SZE made changes - 29/Apr/09 08:53 PM
Resolution Fixed [ 1 ]
Fix Version/s 0.21.0 [ 12313563 ]
Fix Version/s 0.20.1 [ 12313866 ]
Status Patch Available [ 10002 ] Resolved [ 5 ]
Hudson added a comment - 30/Apr/09 06:34 PM
Integrated in Hadoop-trunk #822 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/822/)
. Change Namenode file close log to info.

Owen O'Malley made changes - 08/Jul/09 04:43 PM
Component/s dfs [ 12310710 ]