Resolve findbugs warnings in mapred

• Key: HADOOP-5661
• Type: Bug
• Status: Resolved
• Resolution: Fixed
• Priority: Major
• Assignee: Jothi Padmanabhan
• Reporter: Jothi Padmanabhan
• Fix Version/s: 0.21.0

Description

Towards a solution for HADOOP-5628, we need to resolve all findbugs warnings. This jira will try to resolve the findbugs warnings where ever possible and suppress them where resolution is not possible.

Comments

[Jothi Padmanabhan]

Patch fixing all mapred findbugs warnings

[Jothi Padmanabhan]

ant test and test patch passed with this patch

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12405319/hadoop-5661.patch
against trunk revision 764287.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 9 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

-1 findbugs. The patch appears to introduce 2 new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed core unit tests.

-1 contrib tests. The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/191/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/191/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/191/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/191/console

This message is automatically generated.

[Jothi Padmanabhan]

The findbugs warnings reported for the previous patch did not show up in my local box where findbugs version is 1.3.8. We probably should upgrade the findbugs for the automated testing system to 1.3.8 as well. In the interim, attaching a patch that should handle those two warnings.

The test failures with the previous patch are unrelated.

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12405391/hadoop-5661-v1.patch
against trunk revision 765427.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 9 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed core unit tests.

-1 contrib tests. The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/198/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/198/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/198/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/198/console

This message is automatically generated.

[Jothi Padmanabhan]

Synching patch with the latest trunk

[Amareshwari Sriramadasu]

One comment:
Reducetask.ShuffleRamManager.getNumPendingRequests method need not be public.

[Jothi Padmanabhan]

Changed getNumPendingRequests() to be a private method

[Amareshwari Sriramadasu]

+1 changes look fine to me.

[Jothi Padmanabhan]

ant test and test patch passed on my local box

[Devaraj Das]

I just committed this. Thanks, Jothi!

[Chris Douglas]

TestFairScheduler no longer compiles:

compile:
     [echo] contrib: fairscheduler

compile-examples:

compile-test:
     [echo] contrib: fairscheduler
    [javac] Compiling 1 source file to /snip/hadoop/build/contrib/fairscheduler/test
    [javac] /snip/hadoop/src/contrib/fairscheduler/src/test/org/apache/hadoop/mapred/TestFairScheduler.java:128: cannot find symbol
    [javac] symbol  : constructor ClusterStatus(int,int,int,int,int,org.apache.hadoop.mapred.JobTracker.State)
    [javac] location: class org.apache.hadoop.mapred.ClusterStatus
    [javac]       return new ClusterStatus(numTrackers, maps, reduces,
    [javac]              ^
    [javac] Note: /snip/hadoop/src/contrib/fairscheduler/src/test/org/apache/hadoop/mapred/TestFairScheduler.java uses or overrides a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] 1 error

BUILD FAILED
/snip/hadoop/build.xml:774: The following error occurred while executing this line:
/snip/hadoop/src/contrib/build.xml:48: The following error occurred while executing this line:
/snip/hadoop/src/contrib/build-contrib.xml:165: Compile failed; see the compiler error output for details.

Total time: 1 minute 2 seconds

[Hudson]

Integrated in Hadoop-trunk #811 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/811/)
. Fixes some findbugs warnings in o.a.h.mapred* packages and supresses a bunch of them. Contributed by Jothi Padmanabhan.

[Hudson]

Integrated in Hadoop-trunk #817 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/817/)
HADOOP-5709. Remove redundant synchronization added in . Contributed by Jothi Padmanabhan.