|
[
Permalink
| « Hide
]
Klaas Bosteels added a comment - 10/Mar/09 03:27 PM
The attached patch makes sure that the typecode range 50-200 can be used for application-specific purposes. As an example, it also makes TypedBytesWritableInput and TypedBytesWritableOutput use typecode 50 for serializing Writables that do not match with any of the types supported by the typed bytes format.
Klaas Bosteels made changes - 10/Mar/09 03:27 PM
Klaas Bosteels made changes - 10/Mar/09 03:28 PM
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12401846/HADOOP-5450.patch against trunk revision 752292. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 Eclipse classpath. The patch retains Eclipse classpath integrity. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/46/testReport/ This message is automatically generated. The failed unit tests are not related to the patch.
This should really go into 0.21, so making it a blocker for that release.
Klaas Bosteels made changes - 11/Mar/09 01:36 PM
I just committed this. Thanks, Klaas!
Owen O'Malley made changes - 03/Apr/09 11:23 PM
Integrated in Hadoop-trunk #797 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/797/
. Revert accidental inclusion. . Add application-specific data types to streaming's typed bytes interface. (Klaas Bosteels via omalley)
Owen O'Malley made changes - 08/Jul/09 05:05 PM
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||