JobTracker fails to restart if recovery and ACLs are enabled

• Key: HADOOP-5166
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Blocker
• Assignee: Amar Kamat
• Reporter: Karam Singh
• Affects Version/s: 0.20.0
• Fix Version/s: 0.19.1

Description

JobTracker fails to restart and throw NullPointerException when mapred.jobtracker.restart.recover and mapred.acls.enabled are set to true

2009-02-04 12:28:19,834 FATAL org.apache.hadoop.mapred.JobTracker: java.lang.NullPointerException
at org.apache.hadoop.mapred.QueueManager.hasAccess(QueueManager.java:185)
at org.apache.hadoop.mapred.JobTracker.checkAccess(JobTracker.java:2694)
at org.apache.hadoop.mapred.JobTracker.addJob(JobTracker.java:2663)
at org.apache.hadoop.mapred.JobTracker.access$2300(JobTracker.java:86)
at org.apache.hadoop.mapred.JobTracker$RecoveryManager.recover(JobTracker.java:1099)
at org.apache.hadoop.mapred.JobTracker.offerS

Comments

[Amar Kamat]

A straightforward fix. In JobTracker.java, moving the access check to submitJob() instead of addJob().

[rahul k singh]

reviewed . +1

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12399452/HADOOP-5166-v1.0.patch
against trunk revision 743045.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed core unit tests.

-1 contrib tests. The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3831/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3831/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3831/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3831/console

This message is automatically generated.

[Amar Kamat]

Tests hdfs.TestInjectionForSimulatedStorage.testInjection and chukwa.datacollection.agent.TestAgentConfig.testInitAdaptors_vs_Checkpoint failed. I dont think they are related.

[Amar Kamat]

The current patch applies to 0.20. Attaching a patch for 0.19.

[Hemanth Yamijala]

I committed this to trunk, branches 0.20 and 0.19. Thanks, Amar !

[Hudson]

Integrated in Hadoop-trunk #756 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/756/)