[HADOOP-5087] Regex for Cmd parsing contains an error

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed

Environment

HADOOP-4947 use regex to parse chukwa commands but there's an error in the regex
the current regex is:
Pattern addCmdPattern = Pattern.compile("[aA][dD][dD]\\s+(\\S+)\\s+(\\S+)\\s+(.\\S)?\\s(\\d+)
s*");
does not correctly parsed this valid checkpoint entry:
"ADD org.apache.hadoop.chukwa.datacollection.adaptor.filetailer.CharFileTailingAdaptorUTF8NewLineEscaped Syslog 0 /var/log/messages 114027"
Parsing result:
adaptorName org.apache.hadoop.chukwa.datacollection.adaptor.filetailer.CharFileTailingAdaptorUTF8NewLineEscaped
dataType Syslog
params 0 /var/log/messages 11402
offset 7

Instead of:
adaptorName org.apache.hadoop.chukwa.datacollection.adaptor.filetailer.CharFileTailingAdaptorUTF8NewLineEscaped
dataType Syslog
params 0 /var/log/messages
offset 114027

The correct regex is: "[aA][dD][dD]\\s+(\\S+)\\s+(\\S+)\\s+(.\\s)?\\s(\\d+)
s*"
Example of parsing: "ADD org.apache.hadoop.chukwa.datacollection.adaptor.MySpecificAdaptor Syslog 0 my param1 param2 /var/log/messages 114027";
Parsing result:
adaptorName org.apache.hadoop.chukwa.datacollection.adaptor.MySpecificAdaptor
dataType Syslog
params 0 my param1 param2 /var/log/messages
offset 114027

• Hadoop Flags: Reviewed

Release Note

What is new in HADOOP-5087:

- Fixed the regex to correctly parse the chukwa agent ADD command.
- Added a test case to validate the chukwa agent ADD command.

• Assignee: Ariel Shemaiah Rabkin
• Reporter: Jerome Boulon
• Created: 20/Jan/09 23:56
• Updated: 08/Jul/09 16:40
• Resolved: 03/Mar/09 23:11

Issue Links

• blocks: HADOOP-5036 chukwa agent controller remove file does not work
• is blocked by: HADOOP-5138 Current Chukwa Trunk failed contrib unit tests.