Use the full path when move files to .Trash/Current

• Key: HADOOP-4970
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Prasad Chakka
• Reporter: Prasad Chakka
• Affects Version/s: 0.19.0
• Fix Version/s: 0.20.0

Description

When a directory or file is deleted using rm or rmr, the subtree is moved directly to .Trash/Current. If there are two deleted objects with the same name but with different original paths it is not feasible to undelete them without storing additional information regarding the original paths. Instead if the full path of the deleting object is used while moving (replicating the complete path in .Trash/Current) it will be easier to undelete objects to its original paths.

Comments

[Doug Cutting]

This sounds reasonable to me.

[dhruba borthakur]

+1 on this one.

There could be some confusion when there are multiple paths to the same file (e.g. hard links), but since hdfs does not have hard-links, we can ignore that issue.

[dhruba borthakur]

+1 The code changes look good to me.

[Prasad Chakka]

I ran 'ant -Djava5.home=/usr/local/jdk1.5.0_07 -Dforrest.home=/home/dhruba/forrest -Dfindbugs.home=/home/dhruba/findbugs test-patch -Dpatch.file=../hadoopcore/hadoop-4970.patch' and the output is below

[exec] ======================================================================
[exec] ======================================================================
[exec] Running Eclipse classpath verification.
[exec] ======================================================================
[exec] ======================================================================
[exec]
[exec]
[exec]
[exec]
[exec]
[exec]
[exec] +1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] +1 tests included. The patch appears to include 3 new or modified tests.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec]
[exec]
[exec]
[exec] ======================================================================
[exec] ======================================================================
[exec] Finished build.
[exec] ======================================================================
[exec] ======================================================================

[dhruba borthakur]

I am going to commit this to trunk only. I would not pull this into 0.19 or 0.20 because it is kinda change in semantics.

[Prasad Chakka]

since 0.20 is not already released, it would be nice if you can put this in 0.20.

[dhruba borthakur]

Hi Prasad, can you pl upload a new patch? The current patch does not apply to trunk anymore. Sorry!

[Prasad Chakka]

ported to latest

[dhruba borthakur]

I just committed this. Thanks Prasad!

[Hudson]

Integrated in Hadoop-trunk #756 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/756/)

[Robert Chansler]

Edit release note for publication.