DFSClient should log instead of printing into std err.

• Key: HADOOP-4965
• Type: Bug
• Status: Closed
• Resolution: Fixed
• Priority: Major
• Assignee: Konstantin Shvachko
• Reporter: Konstantin Shvachko
• Component/s: test
• Affects Version/s: 0.17.0
• Fix Version/s: 0.19.1

Description

DFSClient.LeaseChecker.close() uses System.err.println() and Exception.printStackTrace() to output the exception.LOG.error() should be used instead.

Comments

[Suresh Srinivas]

Previously the file name was printed. Should the file name be printed in the log? Otherwise +1 for the patch.

[Tsz Wo (Nicholas), SZE]

This patch may change the shell commands output.

[Konstantin Shvachko]

This patch

• prints the file name;
• stringifyException
• also closes FileSystem in TestFileAppend3

[Steve Loughran]

You shouldn't need to call StringUtils.stringifyException(), because passing it down to the log tools as is lets your logging tool handle the chained strack trace themselves -which can include a more structured output than the stringifyException() call. I'd prefer something like:
LOG.error("Exception closing file " + src + ": " +ie,ie);

[Steve Loughran]

I thought this bugrep was familiar;

[Konstantin Shvachko]

Incorporated Suresh's comment.

[Konstantin Shvachko]

Only one unit test failure with this patch. TestMapReduceLocal fails as in HADOOP-4907.

[Suresh Srinivas]

+1 for the patch

[Konstantin Shvachko]

I am removing the DFSClient related code from the patch because it has been resolved by HADOOP-3894. Leaving only the TestFileAppend3 improvement.

[Konstantin Shvachko]

I just committed this.