|
[
Permlink
| « Hide
]
Owen O'Malley added a comment - 17/Dec/08 11:55 PM
This patch adds JavaDoc to the public methods and changes the getters to take JobContext objects.
[exec] -1 overall.
[exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no tests are needed for this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity. [exec] There are no functional changes in this patch to test. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||