Issue Details (XML | Word | Printable)

Key: HADOOP-4909
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Owen O'Malley
Reporter: Owen O'Malley
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Hadoop Common

Clean up map/reduce api to take JobContext in the static methods

Created: 17/Dec/08 11:53 PM   Updated: 08/Jul/09 04:53 PM
Return to search
Component/s: None
Affects Version/s: None
Fix Version/s: 0.20.0

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works h4909.patch 2008-12-20 08:58 AM Owen O'Malley 26 kB
Text File Licensed for inclusion in ASF works h4909.patch 2008-12-17 11:55 PM Owen O'Malley 25 kB

Hadoop Flags: Reviewed
Resolution Date: 23/Dec/08 06:24 PM


 Description  « Hide
Several of the static methods in the HADOOP-1230 api aren't consistent in that the setters take Job objects and the getters take Configuration objects. It would be better if the getters took JobContext objects.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Owen O'Malley added a comment - 17/Dec/08 11:55 PM
This patch adds JavaDoc to the public methods and changes the getters to take JobContext objects.

Chris Douglas added a comment - 19/Dec/08 11:19 PM
+1

Owen O'Malley added a comment - 20/Dec/08 08:58 AM
Fixed a javadoc warning.

Owen O'Malley added a comment - 20/Dec/08 08:59 AM
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]

There are no functional changes in this patch to test.


Owen O'Malley added a comment - 23/Dec/08 06:24 PM
I just committed this.