Issue Details (XML | Word | Printable)

Key: HADOOP-4778
Type: Bug Bug
Status: Closed Closed
Resolution: Fixed
Priority: Blocker Blocker
Assignee: Tsz Wo (Nicholas), SZE
Reporter: Tsz Wo (Nicholas), SZE
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
Hadoop Common

Check for zero size block meta file when updating a block.

Created: 04/Dec/08 11:12 PM   Updated: 08/Jul/09 04:43 PM
Return to search
Component/s: None
Affects Version/s: None
Fix Version/s: 0.18.3

Time Tracking:
Not Specified

File Attachments:
  Size
Text File Licensed for inclusion in ASF works 4778_20081204.patch 2008-12-05 01:16 AM Tsz Wo (Nicholas), SZE 0.7 kB
Text File Licensed for inclusion in ASF works 4778_20081204_0.18.patch 2008-12-05 09:40 PM Tsz Wo (Nicholas), SZE 0.6 kB

Hadoop Flags: Reviewed
Resolution Date: 05/Dec/08 09:52 PM


 Description  « Hide
In case of datanode running out of disk space, block meta files may be created with zero length. We should detect this obvious problem when updating a block.

 All   Comments   Work Log   Change History   Subversion Commits      Sort Order: Ascending order - Click to sort in descending order
Tsz Wo (Nicholas), SZE added a comment - 04/Dec/08 11:14 PM
4769_20081203.patch: Check for zero size block meta file.

Tsz Wo (Nicholas), SZE made changes - 04/Dec/08 11:14 PM
Field Original Value New Value
Attachment 4769_20081203.patch [ 12395347 ]
Tsz Wo (Nicholas), SZE added a comment - 05/Dec/08 01:16 AM
4778_20081204.patch: should be this file.

Tsz Wo (Nicholas), SZE made changes - 05/Dec/08 01:16 AM
Attachment 4778_20081204.patch [ 12395353 ]
Tsz Wo (Nicholas), SZE added a comment - 05/Dec/08 01:20 AM
     [exec] -1 overall.  

     [exec]     +1 @author.  The patch does not contain any @author tags.

     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
     [exec]                         Please justify why no tests are needed for this patch.

     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.

     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.

     [exec]     +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

The change is trivial. No new tests added.


Tsz Wo (Nicholas), SZE made changes - 05/Dec/08 01:21 AM
Attachment 4769_20081203.patch [ 12395347 ]
Tsz Wo (Nicholas), SZE added a comment - 05/Dec/08 02:12 AM
Passed all tests locally.

Hairong Kuang added a comment - 05/Dec/08 08:06 PM
+1

Tsz Wo (Nicholas), SZE added a comment - 05/Dec/08 09:40 PM
4778_20081204_0.18.patch: for 0.18

Tsz Wo (Nicholas), SZE made changes - 05/Dec/08 09:40 PM
Attachment 4778_20081204_0.18.patch [ 12395448 ]
Repository Revision Date User Message
ASF #723880 Fri Dec 05 21:41:18 UTC 2008 szetszwo HADOOP-4778. Check for zero size block meta file when updating a block. (szetszwo)
Files Changed
MODIFY /hadoop/core/trunk/src/hdfs/org/apache/hadoop/hdfs/server/datanode/FSDataset.java
MODIFY /hadoop/core/trunk/CHANGES.txt

Repository Revision Date User Message
ASF #723882 Fri Dec 05 21:43:07 UTC 2008 szetszwo HADOOP-4778. Check for zero size block meta file when updating a block. (szetszwo)
Files Changed
MODIFY /hadoop/core/branches/branch-0.19/src/hdfs/org/apache/hadoop/hdfs/server/datanode/FSDataset.java
MODIFY /hadoop/core/branches/branch-0.19/CHANGES.txt

Repository Revision Date User Message
ASF #723884 Fri Dec 05 21:44:09 UTC 2008 szetszwo HADOOP-4778. Check for zero size block meta file when updating a block. (szetszwo)
Files Changed
MODIFY /hadoop/core/branches/branch-0.18/src/hdfs/org/apache/hadoop/dfs/FSDataset.java
MODIFY /hadoop/core/branches/branch-0.18/CHANGES.txt

Tsz Wo (Nicholas), SZE added a comment - 05/Dec/08 09:52 PM
I just committed this.

Tsz Wo (Nicholas), SZE made changes - 05/Dec/08 09:52 PM
Resolution Fixed [ 1 ]
Hadoop Flags [Reviewed]
Status Open [ 1 ] Resolved [ 5 ]
Hudson added a comment - 06/Dec/08 02:02 PM

Nigel Daley made changes - 30/Jan/09 08:14 PM
Status Resolved [ 5 ] Closed [ 6 ]
Owen O'Malley made changes - 08/Jul/09 04:43 PM
Component/s dfs [ 12310710 ]