[#HADOOP-4753] gridmix2 code can be condensed

Hadoop Common

gridmix2 code can be condensed

Created: 02/Dec/08 11:29 PM Updated: 23/Apr/09 07:17 PM

Return to search

Component/s:

benchmarks

Affects Version/s:

0.20.0

Fix Version/s:

0.20.0

Time Tracking:

Not Specified

File Attachments:

File Name	Date Attached	Attached By	Size
4753-0.patch	2008-12-02 11:34 PM	Chris Douglas	76 kB
4753-1.patch	2008-12-04 12:47 AM	Chris Douglas	76 kB

Hadoop Flags:	Reviewed
Resolution Date:	16/Dec/08 08:54 PM

Description

« Hide

The gridmix2 benchmark code, particularly GridMixRunner, contains a lot of duplication that can be condensed into a more manageable state.

All

Comments

Work Log

Change History

Subversion Commits

Sort Order:

Chris Douglas made changes - 02/Dec/08 11:34 PM

Field	Original Value	New Value
Attachment		4753-0.patch [ 12395145 ]

Chris Douglas made changes - 02/Dec/08 11:34 PM

Status

Open [ 1 ]

Patch Available [ 10002 ]

[ Permlink | « Hide ]

Chris Douglas added a comment - 04/Dec/08 12:47 AM

Fix a bug in GridMixRunner::select

Chris Douglas made changes - 04/Dec/08 12:47 AM

Attachment

4753-1.patch [ 12395239 ]

[ Permlink | « Hide ]

Hadoop QA added a comment - 08/Dec/08 05:52 AM

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12395239/4753-1.patch
against trunk revision 724229.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

+1 core tests. The patch passed core unit tests.

-1 contrib tests. The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3684/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3684/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3684/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3684/console

This message is automatically generated.

[ Permlink | « Hide ]

Runping Qi added a comment - 16/Dec/08 07:41 PM

Looks good.

Repository	Revision	Date	User	Message
ASF	#727144	Tue Dec 16 20:52:45 UTC 2008	cdouglas	~~HADOOP-4753~~. Refactor gridmix2 to reduce code duplication.
				Files Changed
				DEL /hadoop/core/trunk/src/benchmarks/gridmix2/src/java/org/apache/hadoop/mapred/GridMixConfig.java MODIFY /hadoop/core/trunk/src/benchmarks/gridmix2/src/java/org/apache/hadoop/mapred/GridMixRunner.java MODIFY /hadoop/core/trunk/src/benchmarks/gridmix2/src/java/org/apache/hadoop/mapred/CombinerJobCreator.java MODIFY /hadoop/core/trunk/CHANGES.txt MODIFY /hadoop/core/trunk/src/benchmarks/gridmix2/src/java/org/apache/hadoop/mapred/GenericMRLoadJobCreator.java DEL /hadoop/core/trunk/src/benchmarks/gridmix2/src/java/org/apache/hadoop/mapred/SortJobCreator.java MODIFY /hadoop/core/trunk/src/test/org/apache/hadoop/mapred/GenericMRLoadGenerator.java

Repository	Revision	Date	User	Message
ASF	#727145	Tue Dec 16 20:52:57 UTC 2008	cdouglas	~~HADOOP-4753~~. Refactor gridmix2 to reduce code duplication.
				Files Changed
				MODIFY /hadoop/core/branches/branch-0.20/src/benchmarks/gridmix2/src/java/org/apache/hadoop/mapred/CombinerJobCreator.java DEL /hadoop/core/branches/branch-0.20/src/benchmarks/gridmix2/src/java/org/apache/hadoop/mapred/GridMixConfig.java MODIFY /hadoop/core/branches/branch-0.20/CHANGES.txt MODIFY /hadoop/core/branches/branch-0.20/src/benchmarks/gridmix2/src/java/org/apache/hadoop/mapred/GridMixRunner.java DEL /hadoop/core/branches/branch-0.20/src/benchmarks/gridmix2/src/java/org/apache/hadoop/mapred/SortJobCreator.java MODIFY /hadoop/core/branches/branch-0.20/src/test/org/apache/hadoop/mapred/GenericMRLoadGenerator.java MODIFY /hadoop/core/branches/branch-0.20/src/benchmarks/gridmix2/src/java/org/apache/hadoop/mapred/GenericMRLoadJobCreator.java

[ Permlink | « Hide ]

Chris Douglas added a comment - 16/Dec/08 08:54 PM

I just committed this

Chris Douglas made changes - 16/Dec/08 08:54 PM

Resolution		Fixed [ 1 ]
Hadoop Flags		[Reviewed]
Status	Patch Available [ 10002 ]	Resolved [ 5 ]

[ Permlink | « Hide ]

Hudson added a comment - 22/Dec/08 03:15 PM

Integrated in Hadoop-trunk #698 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/698/)

Nigel Daley made changes - 23/Apr/09 07:17 PM

Status

Resolved [ 5 ]

Closed [ 6 ]