fuse-dfs - create source file/function + utils + config + main source files

• Key: HADOOP-4690
• Type: Improvement
• Status: Closed
• Resolution: Fixed
• Priority: Minor
• Assignee: Pete Wyckoff
• Reporter: Pete Wyckoff
• Fix Version/s: 0.20.0

Description

this will make development easier as all patches don't have to be completely serialized and generally better organizationally.

Comments

[Pete Wyckoff]

this is a cut at it. I broke every fuse implementation into its own file and created various utility files. This will make things more modular and allow more than one diff to happen at a time since all won't be in one file.

I wasn't sure about TestFuseDFS since there's a bunch of setup required to start the minicluster and then mount fuse and should we create separate tests. I guess it could be a bunch of classes - one for each test that testfusedfs could call.

[dhruba borthakur]

+1. Code looks good.

[Hadoop QA]

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12394472/HADOOP-4690.txt
against trunk revision 720698.

+1 @author. The patch does not contain any @author tags.

+1 tests included. The patch appears to include 3 new or modified tests.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 Eclipse classpath. The patch retains Eclipse classpath integrity.

-1 core tests. The patch failed core unit tests.

+1 contrib tests. The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3648/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3648/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3648/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3648/console

This message is automatically generated.

[Pete Wyckoff]

ready to commit - testjobtrackerrestart caused the failure which is not related to this patch as this patch doesn't introduce any changes outside of fuse-dfs.

[Pete Wyckoff]

updated to reflect hadoop 4635 change to TestFuseDFS.

[Mahadev konar]

the patch uploaded is empty ... can you upload the right patch?

[Mahadev konar]

I just committed this. Thanks pete.

[Hudson]

Integrated in Hadoop-trunk #680 (See http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/680/)